Add game tests for IntegratedTerminals advancements; bump ID/CyclopsCore versions#192
Merged
rubensworks merged 5 commits intomaster-1.21-ltsfrom Feb 28, 2026
Merged
Conversation
Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add game tests for all advancements in the mod
Add game tests for all mod advancements
Feb 28, 2026
…fix gui_storage_terminal test Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
Copilot
AI
changed the title
Add game tests for all mod advancements
Add game tests for all IntegratedTerminals advancements
Feb 28, 2026
….0-1630 Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>
Copilot
AI
changed the title
Add game tests for all IntegratedTerminals advancements
Add game tests for IntegratedTerminals advancements; bump ID/CyclopsCore versions
Feb 28, 2026
Copilot stopped work on behalf of
rubensworks due to an error
February 28, 2026 16:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds game tests covering all five IntegratedTerminals advancements and fixes the game test infrastructure so they actually run and pass. Dependency versions are bumped to pick up upstream game test fixes.
Dependency bumps
cyclopscore_version:1.25.1-627→1.26.2-808(fixes game test server infrastructure)integrateddynamics_version:1.30.3-1469→1.32.0-1630Game tests added (
GameTestAdvancementsIntegratedTerminals)testAdvancementRootrootinventoryMenu.broadcastChanges()withpart_display_panelin slot 0testAdvancementMenrilGlassstorage_terminal/menril_glassinventoryMenu.broadcastChanges()withmenril_glassin slot 0testAdvancementCraftStorageTerminalstorage_terminal/craft_storage_terminalPlayerEvent.ItemCraftedEventdirectlytestAdvancementGuiStorageTerminalstorage_terminal/gui_storage_terminalPlayerContainerEvent.OpendirectlytestAdvancementFilterEnchantablestorage_terminal_filtering/filter_enchantablecontainer.onVariableContentsUpdated()with a mockIVariableKey workarounds for the embedded game-test channel
The game test environment uses an embedded Netty channel with no NeoForge custom channel negotiation, so two packet-send failures had to be handled:
integrateddynamics:all_labelson player login —placeNewPlayercompletes all advancement-relevant setup before the failing event fires, so the exception is caught and swallowed:cyclopscore:value_notifyfromContainerExtended.setValue— thrown both duringContainerTerminalStoragePartconstruction and duringonVariableContentsUpdated. Suppressed via an anonymous subclass (virtual dispatch ensures the override fires even from the superclass constructor):InventoryVariableEvaluatorreturningnull— intestAdvancementFilterEnchantable, the evaluator can't resolve the variable because the item isn't registered in the network's variable store. Rather than fighting the evaluator,onVariableContentsUpdatedis called directly with a minimalIVariablestub that returns the expected operator value:💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.